chore(m5): drop CLI connector subcommands#114
Merged
Conversation
PR3 of M5. Removes the spool connector CLI surface; remaining commands (search, sync, list, status, show) are unchanged. - Delete packages/cli/src/commands/connector.ts (489 lines) - Delete packages/cli/src/commands/connector-shared.ts (106 lines) - Drop connectorCommand registration from src/index.ts - Strip 5 connector describe blocks (install/sync/list/status/uninstall/update) from cli.test.ts - Trim SCHEMA_SQL fixture: remove 'connector' source row, captures / captures_fts / captures_fts_trigram / capture_connectors / connector_sync_state tables and indexes Net: -748 / +1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
graydawnc
changed the title
The connector subcommands no longer exist (this branch); strip the "Connector management" + "Available connectors" sections, update the tagline, and drop the captures/connectors mentions from the data location section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 28, 2026
graydawnc
added a commit
that referenced
this pull request
Apr 28, 2026
The 0.4.0 npm publish shipped stale dist artifacts (commands/connector.js and connector-shared.js from before #114 deleted them, plus core's connectors/ subtree from before #115). tsc only writes new files; it does not delete outputs whose source has been removed. The published tarballs were functional (the CLI entry doesn't import the orphans) but ~37 kB heavier than they should be. Fix: prepend `pnpm run clean` (already defined as `rm -rf dist`) to the build script so every fresh build starts from an empty dist/. Verified locally — cli dist now contains only the 5 surviving commands and core dist no longer carries a connectors/ tree. Bump cli + core to 0.4.1 so the clean build can be published. App, landing, and root version stay at 0.4.0 — the Electron release on GitHub is unaffected by this fix and we don't need to cut another DMG just for npm hygiene. Co-authored-by: Chen <99816898+donteatfriedrice@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #112 / #113. Removes the
spool connector ...CLI surface. The other CLI commands (search,sync,list,status,show) are untouched.Changes
packages/cli/src/commands/connector.ts(489 lines) andconnector-shared.ts(106 lines)connectorCommandimport + registration fromsrc/index.tsdescribe('connector ...')blocks fromcli.test.ts(install / sync / list / status / uninstall / update)SCHEMA_SQLtest fixture: remove'connector'source row +captures/captures_fts/captures_fts_trigram/capture_connectors/connector_sync_statetables and their indexespackages/cli/README.md: drop the "Connector management" + "Available connectors" sections, update the tagline, and remove the captures/connectors mentions from the data-location section-770 / +3net.Out of scope (cross-cutting docs — landing site, root README,
docs/connector-*.md, design docs) — these will be batched in a later docs pass.Features that should still work post-PR (verified)
spool --helpconnectorspool connector ...error: unknown command 'connector'spool syncspool status5 total (claude: 5, codex: 0, gemini: 0)against the seeded DBspool listspool search XYLOPHONE_CANARY_42spool show <uuid>pnpm test(cli package)pnpm build(cli package)Test plan
pnpm exec tscclean (cli package)pnpm testpasses (21 tests, 0 failures, 16 connector tests removed with their describes)bin/spool.jsfor each surviving command (table above)spool connector listnow exits 1 with the expected commander errorpackages/cli/README.mdreviewed — every remaining example matches a still-existing command🤖 Generated with Claude Code